Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement Sniff to ensure a blank line before an object's closing brace #173

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

jaymcp
Copy link
Member

@jaymcp jaymcp commented Mar 24, 2025

Description

Our coding standards require a blank line between an object (class, enum, interface, trait) definition's last content and closing brace, but this is not enforced by our PHPCS ruleset. This PR addresses that by introducing a new Sniff.

Types of changes (if applicable):

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist (if applicable):

  • All checks pass when running `composer run all-checks.

@jaymcp jaymcp requested a review from a team March 24, 2025 10:03
@jaymcp jaymcp merged commit eb4c986 into main Apr 4, 2025
5 checks passed
@jaymcp jaymcp deleted the feat/closing-brace-sniff branch April 4, 2025 10:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant