Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add [type] support to <ol> breadcrumbs. #72

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

geoffrey-eisenbarth
Copy link
Collaborator

Allow users to opt in to numbers in <ol> breadcrumbs via the [type] attribute.

@geoffrey-eisenbarth
Copy link
Collaborator Author

geoffrey-eisenbarth commented Jan 6, 2025

I also added support for [aria-current=step], since I was drafting this up in the context of a checkout flow.

What do you think about replacing the separator / with e.g. > or when the breadcrumbs contains [aria-current=step]?

Edit: perhaps in the spirit of issue #58, we can specify it with --breadcrumb-separator?

@geoffrey-eisenbarth geoffrey-eisenbarth self-assigned this Jan 6, 2025
@geoffrey-eisenbarth
Copy link
Collaborator Author

geoffrey-eisenbarth commented Jan 16, 2025

Another thought: we could replace the :is(ul, ol)[role=list] styling with :is(ul, ol)[type=none] (e.g., set padding-inline-start:0).

Two possibly inconsequential asides:

  • Lighthouse balks at <ul role=list> without explicit role=listitem children 🙄
  • MDN says ul[type] is depreciated :(

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant