Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

percentage completed on tft #9

Open
chick911t opened this issue Mar 7, 2021 · 4 comments
Open

percentage completed on tft #9

chick911t opened this issue Mar 7, 2021 · 4 comments

Comments

@chick911t
Copy link

Hi there on the tft it is saying that there is a percentage completed before the print has even started using cura 4.8 and tft35_E3_E3.0.26.x feb 26 2021 firmware on tft35 e3
https://imgur.com/gallery/L5i0hc1

@flatcapper
Copy link

flatcapper commented Mar 8, 2021 via email

@bigtreetech
Copy link
Owner

In the changes to Gcode made by this tool, I have added some additional parsing functions to ensure that these unexpected codes will not be added in some files that do not need additional Gcode. You can update the tool and use it again. If there are still problems, you can show me specific error information by uploading pictures and videos, etc. That way I can locate the problem more quickly.

@chick911t
Copy link
Author

In the changes to Gcode made by this tool, I have added some additional parsing functions to ensure that these unexpected codes will not be added in some files that do not need additional Gcode. You can update the tool and use it again. If there are still problems, you can show me specific error information by uploading pictures and videos, etc. That way I can locate the problem more quickly.

Hi there the problem wasn't rectified percentage say e.i. 70% ic completed before the print has even started

@tttttim5
Copy link

Hello,
I think I have found the problem, but I do not know how to fix this. The problem is that the gcode is expanded by 337930 chars. The software than thinks that already a certain amount of characters/lines in the gcode has past, so it does not start at 0%.
I tried to subtract this number of chars from a certain parameters like "infoPrinting.cur = cur;" and "infoPrinting.size = size;" in "Printing.c", but this did not influenced it.
Another suggestion to fix this is in "Printing.c" the for-loop "for (; infoPrinting.cur < infoPrinting.size;)". In this the first gcode can be ignored, but I did not know how (I updated "comment_count" and added a "\n" in the gcode, but without results).
I also checked with the "cmd_index" in "interfaceCmd.c", but also without results.
The last thing I think can be changed is the "ack_value()" in "parseACK.c". I do not understand this value, but I think a compensation for these extra chars can be included here.
There can also be written some function which checks after reading all the gcode (or partly) whether it can find "bigtree thumbnail end" as this is added from the plugin. If so, it can ignore all the gcode prior to this.

@bigtreetech, do you think you can do something with this information? If not, please let me know.
Oh and if you could share the updated code and in which file on this comment, that would be great! If the changes are bigger than only a few lines in one file, please let us know if you have included this fix in the normal software.

Thanks in advance!!!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants