Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Switch to using forked version of Davrods #9

Closed
mikkonie opened this issue Nov 15, 2024 · 1 comment
Closed

Switch to using forked version of Davrods #9

mikkonie opened this issue Nov 15, 2024 · 1 comment
Assignees
Labels
environment Issues regarding dependencies, CI, deployment etc.
Milestone

Comments

@mikkonie
Copy link
Contributor

While doing #3, I'm doing ugly sed hacks to edit the Davrods repo in order to work with iRODS 4.3, token passwords etc.

Instead, I should fork the repo, make the changes there and have a "clean" dependency.

Bits to edit directly in forked repo:

  • sed -i 's/rods_auth_ttl = 1/rods_auth_ttl = 336/g' /tmp/davrods/src/config.c
  • sed -i 's/strlen(password) > 63/strlen(password) > 128/g' /tmp/davrods/src/auth.c
  • sed -i 's/module AP_MODULE_DECLARE_DATA davrods_module;/extern module AP_MODULE_DECLARE_DATA davrods_module;/g' /tmp/davrods/src/mod_davrods.h

TBD: Leave the iRODS package version replacement as is or improve this somehow? Ideally it should be modifiable by an env var, IMHO.

I want to make sure everything is properly working for #3 and #6 before I do this. Hence a separate issue.

@mikkonie mikkonie added the environment Issues regarding dependencies, CI, deployment etc. label Nov 15, 2024
@mikkonie mikkonie added this to the 4.3.x-1 milestone Nov 15, 2024
@mikkonie mikkonie self-assigned this Nov 15, 2024
@mikkonie
Copy link
Contributor Author

Done.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
environment Issues regarding dependencies, CI, deployment etc.
Projects
None yet
Development

No branches or pull requests

1 participant