Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ensure refresh token is stored #696

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

rikroe
Copy link
Member

@rikroe rikroe commented Nov 29, 2024

Proposed change

If an exception occured (e.g. connection issue or remote service issue), a new refresh_token was not saved to disk in CLI.
This PR ensures that tokens are saved.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this library)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works.

@rikroe rikroe merged commit cd6e967 into bimmerconnected:master Nov 29, 2024
12 checks passed
@rikroe rikroe deleted the cli-storage branch December 25, 2024 12:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant