Skip to content

upgrade perl to v5.40.0 #35

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 3 commits into
base: perl_40
Choose a base branch
from

Conversation

ngeojiajun-deriv
Copy link

No description provided.

Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

@ngeojiajun-deriv
Copy link
Author

Why changing the base image for myriad? The package should have been installed automatically during the build process

@ngeojiajun-deriv ngeojiajun-deriv changed the base branch from master to perl_40 January 13, 2025 09:56
Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

Copy link

@diego-deriv diego-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this build both branches?

@ngeojiajun-deriv
Copy link
Author

Yes and no, we need at least the changes for perl_40 but I simply update the one for master so it is easily to reconcile the changes later

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants