Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update analyze CSV output settings #119

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Update analyze CSV output settings #119

merged 1 commit into from
Oct 23, 2018

Conversation

MSiggel
Copy link
Contributor

@MSiggel MSiggel commented Oct 23, 2018

Fixes #95

Changes made in this pull request:

  • saner csv output names
  • default behavior of analyze changed such that by default no csv is saved.
  • when invoking --save-csv a file is saved

PR Checklist

  • Added changelog fragment in ./changelog/ (more information)?
  • Issue raised/referenced?

Copy link
Contributor

@mimischi mimischi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change, one question. Otherwise we are good to go!

mdbenchmark/analyze.py Outdated Show resolved Hide resolved
mdbenchmark/analyze.py Show resolved Hide resolved
@MSiggel MSiggel force-pushed the csv-fix branch 2 times, most recently from bd82cfe to ea455be Compare October 23, 2018 09:14
@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #119 into develop will decrease coverage by 0.43%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #119      +/-   ##
===========================================
- Coverage    96.54%   96.11%   -0.44%     
===========================================
  Files           14       14              
  Lines          723      720       -3     
===========================================
- Hits           698      692       -6     
- Misses          25       28       +3
Impacted Files Coverage Δ
mdbenchmark/utils.py 96.33% <ø> (-2.77%) ⬇️
mdbenchmark/analyze.py 71.05% <50%> (-1.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20d1e7f...cc88adf. Read the comment docs.

@MSiggel MSiggel force-pushed the csv-fix branch 3 times, most recently from 81d87b1 to 5adebc0 Compare October 23, 2018 15:15
@mimischi
Copy link
Contributor

Oh, this is actually missing a changelog file @MSiggel. Could you please add this? Then we're really finished.

@mimischi mimischi merged commit 099ddb3 into develop Oct 23, 2018
@mimischi mimischi deleted the csv-fix branch October 23, 2018 15:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants