Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Let user change the job name of benchmarks #125

Merged
merged 3 commits into from
Oct 23, 2018
Merged

Let user change the job name of benchmarks #125

merged 3 commits into from
Oct 23, 2018

Conversation

mimischi
Copy link
Contributor

@mimischi mimischi commented Oct 23, 2018

Fixes #85

Changes made in this pull request:

  • Added --job-name option to mdbenchmark generate.
  • Added new variable {{ job_name }} to be rendered in job templates.
  • Changed all MPCDF templates to include the new variable {{ job_name }}.

PR Checklist

  • Added changelog fragment in ./changelog/ (more information)?
  • Issue raised/referenced?

@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #125 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #125      +/-   ##
===========================================
+ Coverage    96.11%   96.12%   +0.01%     
===========================================
  Files           14       14              
  Lines          720      723       +3     
===========================================
+ Hits           692      695       +3     
  Misses          28       28
Impacted Files Coverage Δ
mdbenchmark/generate.py 100% <100%> (ø) ⬆️
mdbenchmark/mdengines/utils.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 099ddb3...06ad353. Read the comment docs.

@mimischi mimischi merged commit 742c5c4 into develop Oct 23, 2018
@mimischi mimischi deleted the jobname branch October 23, 2018 17:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant