Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix the --force restart #146

Merged
merged 2 commits into from
Apr 10, 2019
Merged

Fix the --force restart #146

merged 2 commits into from
Apr 10, 2019

Conversation

mimischi
Copy link
Contributor

@mimischi mimischi commented Apr 10, 2019

Resolves #141.

Changes made in this pull request:

  • Found a typo that prohibited forced restarts of benchmarks.

PR Checklist

  • Added changelog fragment in ./changelog/ (more information)?
  • Issue raised/referenced?

@mimischi
Copy link
Contributor Author

This really should have been catched by a unit test, but our current code structure needs mocking of detect_md_engine() and this is where the error actually arises.

@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #146 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #146   +/-   ##
========================================
  Coverage    95.86%   95.86%           
========================================
  Files           14       14           
  Lines          750      750           
========================================
  Hits           719      719           
  Misses          31       31
Impacted Files Coverage Δ
mdbenchmark/submit.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8813800...f045058. Read the comment docs.

@mimischi mimischi merged commit 876568c into develop Apr 10, 2019
@mimischi mimischi deleted the force-restart branch April 10, 2019 09:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant