Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Name of TPR file can now contain the file extension. #32

Merged
merged 2 commits into from
Feb 12, 2018
Merged

Conversation

mimischi
Copy link
Contributor

@mimischi mimischi commented Feb 11, 2018

Fixes #31.

Changes made in this Pull Request:

  • Name of TPR file can now contain the file extension.

PR Checklist

  • CHANGELOG updated (added news fragment into changelog directory)?
  • Issue raised/referenced?

* Modified test to work for both cases.

Fixes #31.

Add test
@codecov
Copy link

codecov bot commented Feb 11, 2018

Codecov Report

Merging #32 into master will increase coverage by 0.31%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   66.25%   66.56%   +0.31%     
==========================================
  Files          10       10              
  Lines         323      326       +3     
==========================================
+ Hits          214      217       +3     
  Misses        109      109
Impacted Files Coverage Δ
mdbenchmark/generate.py 89.28% <100%> (+0.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17513de...8e2ab52. Read the comment docs.

Copy link
Contributor

@kain88-de kain88-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good besides the missing changelog entry

@mimischi mimischi merged commit 58c4d02 into master Feb 12, 2018
@mimischi mimischi deleted the filename branch February 12, 2018 09:30
mimischi added a commit that referenced this pull request Feb 21, 2018
Name of TPR file can now contain the file extension.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants