Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add --cpu flag to generate #69

Merged
merged 6 commits into from
Jul 25, 2018
Merged

Add --cpu flag to generate #69

merged 6 commits into from
Jul 25, 2018

Conversation

mimischi
Copy link
Contributor

@mimischi mimischi commented May 18, 2018

Fixes #66.

Changes made in this pull request:

  • mdbenchmark generate now accepts --cpu / --no-cpu, as well as a --gpu / --no-gpu options. If given both --cpu and --gpu, it will generate both benchmarks at once. The default is --cpu and --no-gpu.

PR Checklist

  • Added changelog fragment in ./changelog/ (more information)?
  • Issue raised/referenced?

@mimischi mimischi requested a review from kain88-de May 18, 2018 14:57
@mimischi mimischi force-pushed the cpuflag branch 3 times, most recently from 8ddfa38 to 14b6da8 Compare May 18, 2018 15:19
@codecov
Copy link

codecov bot commented May 18, 2018

Codecov Report

Merging #69 into develop will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #69      +/-   ##
===========================================
+ Coverage    96.47%   96.53%   +0.06%     
===========================================
  Files           13       13              
  Lines          567      578      +11     
===========================================
+ Hits           547      558      +11     
  Misses          20       20
Impacted Files Coverage Δ
mdbenchmark/generate.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95fb6fb...ba71a6c. Read the comment docs.

mimischi added 5 commits July 25, 2018 10:43
* Update generate_output fixture
* Add generate_output_create and generate_output_finish fixtures
@mimischi mimischi changed the base branch from master to develop July 25, 2018 08:47
@mimischi mimischi merged commit 5da6925 into develop Jul 25, 2018
@mimischi mimischi deleted the cpuflag branch July 25, 2018 09:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant