Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

style: add new linting checks #34

Merged
merged 3 commits into from
Feb 10, 2023
Merged

style: add new linting checks #34

merged 3 commits into from
Feb 10, 2023

Conversation

jsstevenson
Copy link
Contributor

korikuzma
korikuzma approved these changes Feb 10, 2023
View reviewed changes
.github/workflows/ci.yaml Outdated

on:
push:
branches: [ main ]
Copy link
Contributor

@korikuzma korikuzma Feb 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we only want to run CI on the main branch? I think it's nice when pushing to a branch to see if checks pass before I open a PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think that makes sense

@jsstevenson jsstevenson merged commit 1c01e48 into main Feb 10, 2023
@jsstevenson jsstevenson deleted the ci branch February 10, 2023 18:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@korikuzma korikuzma korikuzma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsstevenson @korikuzma