Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

22.01 #97

Merged
merged 21 commits into from
Feb 7, 2022
Merged

22.01 #97

merged 21 commits into from
Feb 7, 2022

Conversation

HadleyKing
Copy link
Contributor

No description provided.

On branch 22.01
Changes to be committed:
	modified:   README.md
	deleted:    VERSION.py
	modified:   config.toml
	modified:   content/bco-domains.md
	renamed:    content/extension-scm.md -> content/extension-domain.md
	deleted:    content/extension-fhir.md
	modified:   content/provenance-domain.md
	modified:   content/usability-domain.md
	modified:   content/user_guide.md
Changes to be committed:
	modified:   content/description-domain.md
	modified:   content/execution-domain.md
	modified:   content/parametric-domain.md
@HadleyKing HadleyKing added the Documetation Relating to documentation, not code or functionality label Jan 14, 2022
Copy link
Contributor

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a summary of changes since the last version?

content/provenance-domain.md Outdated Show resolved Hide resolved
Added language about object_id versioning and prefix
Changes to be committed:
	modified:   content/provenance-domain.md
	modified:   content/top-level.md
Changes to be committed:
	modified:   content/examples/HCV1a.json
	modified:   content/examples/HIVE_metagenomics.json
	modified:   content/examples/UVP.json
	modified:   content/examples/glycosylation-sites-UniCarbKB.json
	modified:   content/top-level.md
content/top-level.md Outdated Show resolved Hide resolved
Changes to be committed:
	modified:   content/faq.md
	modified:   content/sop.md
response to Issue #72
Changes to be committed:
	modified:   content/faq.md
#97 (review)
Changes to be committed:
	modified:   content/faq.md
	modified:   content/provenance-domain.md
	modified:   content/top-level.md
@HadleyKing
Copy link
Contributor Author

Is there a summary of changes since the last version?

What's Changed

Full Changelog: 1.4.2...22.01

@HadleyKing
Copy link
Contributor Author

@mr-c Its a lot since we stoped tracking versions once we realized that IEEE-2791-2020 would be the repo for the standard. This repo has been repurposed to house the documentation, and so this PR will be the first release to be inline with the BCO Portal and DB release.

@HadleyKing HadleyKing requested a review from mr-c January 17, 2022 15:24
@HadleyKing HadleyKing added this to the 22.02 milestone Jan 31, 2022
@HadleyKing HadleyKing added the LifeSpan 1 This issue has been passed from one milestone to the next label Jan 31, 2022
Copy link
Contributor

@kee007ney kee007ney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes made.

I know that this came up before, but why is the external references field only for publicly accessible data, forcing non-public data to find a home somewhere else?

@HadleyKing
Copy link
Contributor Author

Minor changes made.

I know that this came up before, but why is the external references field only for publicly accessible data, forcing non-public data to find a home somewhere else?

@kee007ney where do you see that? Actually the external_data_endpoints should also be used for non public data. I think that was the original intention. So a consumer knows what access privileges they need.

Copy link
Contributor

@jpat1546 jpat1546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made minor changes to text.

@HadleyKing HadleyKing merged commit a1a9c4c into main Feb 7, 2022
@HadleyKing HadleyKing deleted the 22.01 branch February 7, 2022 20:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Documetation Relating to documentation, not code or functionality LifeSpan 1 This issue has been passed from one milestone to the next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants