Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

spatial extension v1 #9

Merged
merged 7 commits into from
Sep 3, 2024
Merged

spatial extension v1 #9

merged 7 commits into from
Sep 3, 2024

Conversation

pfeiferl
Copy link
Contributor

Hey guys, I just finished a new spatial extension for scdrake, especially focusing on data generated by Visium technology. Features added: spatial pseudo-tissue visualization, spatially variable genes selection, and manual annotation using expression signatures (for both single-cell and spatial data). Please, kindly review these sections once you have time. I hope everything will work fine this time. Thank you!

@pfeiferl pfeiferl requested review from gorgitko and vucinick July 11, 2024 12:49
@vucinick
Copy link
Contributor

Hi,

I started the review a week ago and noted several comments regarding semantics. I recommended to Lucie (@pfeiferl) to use the lintr package, which will allow me to focus more on the logic of the code. Writing this here to document our in-person discussion.

Thanks! 😃

@pfeiferl
Copy link
Contributor Author

Hi,

thank you! As suggested, I formatted the code (but used styler as recommended by @gorgitko). I am now waiting for the finished patch by @vucinick, then I will merge the pipelines, and push changes ☺️

_drake_single_sample.R Outdated Show resolved Hide resolved
@pfeiferl pfeiferl requested review from gorgitko and removed request for vucinick September 3, 2024 17:51
@gorgitko gorgitko merged commit ae3452f into main Sep 3, 2024
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants