DcmSend: abort associations when I/O errors on cstore mid transfer

bioinformatics-ua · Dec 19, 2024 · 23897f8 · 23897f8
1 parent 8a64b37
commit 23897f8
Showing 1 changed file with 13 additions and 3 deletions.
diff --git a/dicoogle/src/main/java/pt/ua/dicoogle/server/queryretrieve/DicoogleDcmSend.java b/dicoogle/src/main/java/pt/ua/dicoogle/server/queryretrieve/DicoogleDcmSend.java
@@ -498,17 +498,27 @@ public void onDimseRSP(Association as, DicomObject cmd, DicomObject data) {
             } catch (NoPresentationContextException e) {
                 LOGGER.warn("Cannot send {}: {}", info.item.getURI(), e.getMessage());
             } catch (IOException e) {
-                LOGGER.error("Failed to send {}", info.item.getURI(), e);
+                LOGGER.error("Fatal I/O error while sending {}", info.item.getURI(), e);
+                // since this exception can be thrown mid-transfer,
+                // the sending process cannot be recovered.
+                // Abort the association and return.
+                try {
+                    assoc.abort();
+                } catch (Exception ex) {
+                    // ignore
+                    LOGGER.warn("Association could not be aborted: {}", ex.getMessage());
+                }
+                return;
             } catch (InterruptedException e) {
                 // should not happen
-                e.printStackTrace();
+                throw new RuntimeException(e);
             }
         }
         try {
             assoc.waitForDimseRSP();
         } catch (InterruptedException e) {
             // should not happen
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }