-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Define to disable ON/OFF beeps / optimisations #66
base: master
Are you sure you want to change the base?
Conversation
Is there a need to speed up the main loop? I'd rather eliminate all the preprocessor switches than add new ones. |
Whoops, just wanted to make a PR to your branch but commited directly by accident (why do I even have the right to do that? ;) ) Anyways, changed your platformio.ini to be compatible to the new config structure. |
Yes also did this exact change but not pushed it yet. |
I guess @btsimonh and I developed a heavy dislike against using preprocessor switches in the last months ;) Lots of (maybe) dead code and too many possible configurations which can interfere. Impossible to test. By putting everything in variables and having a runtime config you can still set the options while flashing. As soon as the "magic" changes, defaults are used. |
In this PR:
instead of
for example