Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Run time limits #42

Closed
Geal opened this issue Dec 21, 2020 · 1 comment · Fixed by #45
Closed

Run time limits #42

Geal opened this issue Dec 21, 2020 · 1 comment · Fixed by #45
Assignees
@daeMOn63

Comments

@Geal
Copy link
Contributor

Geal commented Dec 21, 2020

cf biscuit-auth/biscuit#53 I added some limits to the Datalog engine execution in the Rust and Java version, to limit the number of facts ( memory usage), iterations and run time. It would be a good idea to add them ;)
@daeMOn63
Copy link
Contributor

Yep, definitively a good idea to add this. I've added some restriction on the biscuit size in one of our clients, but this extra run time limit is better.

daeMOn63 added a commit that referenced this issue Jan 11, 2021
@daeMOn63
datalog: add world run limits
40e17b3 
introduce run limits to the datalog world,
allowing to stop the execution when the processing
 - takes too long
 - generates too many facts
 - exceeds the iteration limit

fix #42
@daeMOn63 daeMOn63 mentioned this issue Jan 11, 2021
Merged
@daeMOn63 daeMOn63 self-assigned this Jan 11, 2021
daeMOn63 added a commit that referenced this issue Jan 12, 2021
@daeMOn63
datalog: add world run limits
1f63389 
introduce run limits to the datalog world,
allowing to stop the execution when the processing
 - takes too long
 - generates too many facts
 - exceeds the iteration limit

fix #42
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@daeMOn63 daeMOn63

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

datalog: add world run limits biscuit-auth/biscuit-go
2 participants
@Geal @daeMOn63