Skip to content

Add Reserve method for fixed-size write batches #48

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: bitcoin-fork
Choose a base branch
from
Open

Add Reserve method for fixed-size write batches #48

wants to merge 1 commit into from

Conversation

l0rinc
Copy link

@l0rinc l0rinc commented Mar 24, 2025

Clone of google#1259

In case of Bitcoin Core the batch sizes at the final UTXO set are fixed (16 MiB currently).
This could enable us pre-sizing the batch, if we had access to such a method, to avoid increasing memory copies at a critical time, when the memory is already saturated maximally - see bitcoin-dev-tools/benchcoin#136.

laanwj
laanwj approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@laanwj laanwj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept and code review ACK 6737623

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@laanwj laanwj laanwj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l0rinc @laanwj