Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(BUX-397): acceptance and rejection of establishing contacts #512

Merged
merged 13 commits into from
Mar 29, 2024

Conversation

jakubmkowalski
Copy link
Contributor

@jakubmkowalski jakubmkowalski commented Mar 20, 2024

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

Copy link

github-actions bot commented Mar 20, 2024

Manual Tests

πŸ’š Manual testing by @arkadiuszos4chain resulted in success.

@jakubmkowalski jakubmkowalski force-pushed the feat-397-acceptance-of-establishing-contacts branch from 6138c08 to 3d82fab Compare March 26, 2024 17:12
Base automatically changed from feat-395-pike-capability to master March 27, 2024 15:08
@jakubmkowalski jakubmkowalski force-pushed the feat-397-acceptance-of-establishing-contacts branch from 3d82fab to 9add3a1 Compare March 28, 2024 09:54
@jakubmkowalski jakubmkowalski marked this pull request as ready for review March 28, 2024 10:42
@jakubmkowalski jakubmkowalski requested a review from a team as a code owner March 28, 2024 10:42
actions/contacts/reject.go Outdated Show resolved Hide resolved
engine/action_contact.go Outdated Show resolved Hide resolved
engine/action_contact.go Outdated Show resolved Hide resolved
engine/action_contact.go Show resolved Hide resolved
engine/action_contact.go Show resolved Hide resolved
engine/action_contact.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.24390% with 49 lines in your changes are missing coverage. Please review.

Project coverage is 52.59%. Comparing base (663b991) to head (2d69b0b).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #512      +/-   ##
==========================================
- Coverage   52.69%   52.59%   -0.10%     
==========================================
  Files         184      186       +2     
  Lines       10731    10810      +79     
==========================================
+ Hits         5655     5686      +31     
- Misses       4529     4573      +44     
- Partials      547      551       +4     
Flag Coverage Ξ”
unittests 52.59% <40.24%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
actions/contacts/routes.go 100.00% <100.00%> (ΓΈ)
engine/model_contact_status.go 69.23% <ΓΈ> (ΓΈ)
engine/action_paymails.go 50.47% <0.00%> (-0.49%) ⬇️
engine/model_contact.go 72.44% <50.00%> (-2.02%) ⬇️
actions/contacts/accept.go 0.00% <0.00%> (ΓΈ)
actions/contacts/reject.go 0.00% <0.00%> (ΓΈ)
engine/action_contact.go 62.34% <63.63%> (+0.48%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 663b991...2d69b0b. Read the comment docs.

@arkadiuszos4chain arkadiuszos4chain self-requested a review March 28, 2024 16:57
@jakubmkowalski jakubmkowalski force-pushed the feat-397-acceptance-of-establishing-contacts branch from 2d69b0b to ecbd194 Compare March 29, 2024 09:47
@arkadiuszos4chain
Copy link
Contributor

testing

@arkadiuszos4chain arkadiuszos4chain added the tested PR was tested by a team member label Mar 29, 2024
@jakubmkowalski jakubmkowalski merged commit 354dc4b into master Mar 29, 2024
9 checks passed
@jakubmkowalski jakubmkowalski deleted the feat-397-acceptance-of-establishing-contacts branch March 29, 2024 13:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants