Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(BUX-686): checking nil pointer to nil Metadata #528

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

chris-4chain
Copy link
Contributor

@chris-4chain chris-4chain commented Apr 4, 2024

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@chris-4chain chris-4chain requested a review from a team as a code owner April 4, 2024 13:35
Copy link

github-actions bot commented Apr 4, 2024

Manual Tests

πŸ’š Manual testing by @dorzepowski resulted in success.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 52.86%. Comparing base (e06f774) to head (177fc64).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
- Coverage   52.89%   52.86%   -0.03%     
==========================================
  Files         189      189              
  Lines       10847    10857      +10     
==========================================
+ Hits         5737     5740       +3     
- Misses       4560     4564       +4     
- Partials      550      553       +3     
Flag Coverage Ξ”
unittests 52.86% <30.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
engine/datastore/where_builder.go 86.53% <30.00%> (-3.88%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update e06f774...177fc64. Read the comment docs.

@dorzepowski dorzepowski added the tested PR was tested by a team member label Apr 5, 2024
@chris-4chain chris-4chain merged commit 1229a1a into master Apr 5, 2024
9 of 10 checks passed
@chris-4chain chris-4chain deleted the fix-isNilCondition branch April 5, 2024 07:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants