feat(BUX-685): sql-injection safe filters #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manual Testsℹ️ Remember to ask team members to perform manual tests and to assign |
| applyConditionsIfNotNil(conditions, "created_at", mf.CreatedRange.ToDbConditions()) | ||
| applyConditionsIfNotNil(conditions, "updated_at", mf.UpdatedRange.ToDbConditions()) | ||
|
|
||
| if mf.IncludeDeleted == nil || !*mf.IncludeDeleted { |
There was a problem hiding this comment.
If we have 2 records. One active and second is deleted. With this condition we can get one of them or both ?
There was a problem hiding this comment.
As the IncludeDeleted field says:
When we have two records: deleted-record and normal-record
- when
IncludeDeletedis set to true - we'll getdeleted-recordandnormal-record - when
IncludeDeletedis nil or is set to false - we'll get onlynormal-record
Nazarii-4chain
approved these changes
Apr 5, 2024
Nazarii-4chain
merged commit 34e270e
into
BUX-685/SqlInjectionStatic
2 of 3 checks passed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist