Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(BUX-754): PATCH endpoint for unconfirmed contact #552

Merged
merged 1 commit into from
May 6, 2024

Conversation

kuba-4chain
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@kuba-4chain kuba-4chain requested a review from a team as a code owner April 18, 2024 08:34
Copy link

github-actions bot commented Apr 18, 2024

Manual Tests

πŸ’š Manual testing by @javattor resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 41.17647% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 52.37%. Comparing base (dfd7887) to head (38a1080).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
- Coverage   52.40%   52.37%   -0.03%     
==========================================
  Files         197      198       +1     
  Lines       11081    11115      +34     
==========================================
+ Hits         5807     5822      +15     
- Misses       4724     4740      +16     
- Partials      550      553       +3     
Flag Coverage Ξ”
unittests 52.37% <41.17%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
actions/contacts/routes.go 100.00% <100.00%> (ΓΈ)
engine/model_contact.go 70.19% <100.00%> (+1.02%) ⬆️
engine/action_contact.go 48.37% <57.14%> (+1.10%) ⬆️
actions/contacts/unconfirm.go 0.00% <0.00%> (ΓΈ)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update dfd7887...38a1080. Read the comment docs.

@mariusz-4chain
Copy link
Contributor

testing

@mariusz-4chain mariusz-4chain added the tested PR was tested by a team member label Apr 26, 2024
@kuba-4chain kuba-4chain force-pushed the feat-754-unconfirm-contact branch from cff94e7 to 38a1080 Compare May 6, 2024 10:22
@mariusz-4chain mariusz-4chain added tested PR was tested by a team member and removed tested PR was tested by a team member labels May 6, 2024
@kuba-4chain kuba-4chain merged commit 14f361a into main May 6, 2024
13 of 14 checks passed
@kuba-4chain kuba-4chain deleted the feat-754-unconfirm-contact branch May 6, 2024 10:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants