Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(BUX-750): add admin contact endpoints #555

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

pawellewandowski98
Copy link
Contributor

@pawellewandowski98 pawellewandowski98 commented Apr 19, 2024

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

Description

Added contacts endpoints for admin:

  • POST /admin/contact/search - search for contacts
  • PATCH /admin/contact/:id - update contact name and metadata
  • PATCH /admin/contact/rejected/:id - reject contact
  • PATCH /admin/contact/unconfirmed/:id- change confirmed contact to unconfirmed

@pawellewandowski98 pawellewandowski98 self-assigned this Apr 19, 2024
@pawellewandowski98 pawellewandowski98 requested a review from a team as a code owner April 19, 2024 10:39
Copy link

github-actions bot commented Apr 19, 2024

Manual Tests

πŸ’š Manual testing by @jakubmkowalski resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 3.65854% with 158 lines in your changes are missing coverage. Please review.

Project coverage is 52.43%. Comparing base (1a2042f) to head (2b01d64).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
- Coverage   53.16%   52.43%   -0.73%     
==========================================
  Files         195      197       +2     
  Lines       10912    11072     +160     
==========================================
+ Hits         5801     5806       +5     
- Misses       4561     4716     +155     
  Partials      550      550              
Flag Coverage Ξ”
unittests 52.43% <3.65%> (-0.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
actions/admin/routes.go 100.00% <100.00%> (ΓΈ)
engine/model_contact_status.go 69.23% <ΓΈ> (ΓΈ)
actions/contacts/search.go 0.00% <0.00%> (ΓΈ)
models/filter/contact_filter.go 0.00% <0.00%> (ΓΈ)
engine/model_contact.go 69.17% <4.54%> (-11.63%) ⬇️
engine/action_contact.go 47.26% <0.00%> (-16.07%) ⬇️
actions/admin/contact.go 0.00% <0.00%> (ΓΈ)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 1a2042f...2b01d64. Read the comment docs.

@pawellewandowski98 pawellewandowski98 force-pushed the feat-750-add-admin-contact-endpoints branch from 3b51a6f to d0f8414 Compare April 19, 2024 10:41
actions/admin/contact.go Outdated Show resolved Hide resolved
actions/admin/contact.go Show resolved Hide resolved
engine/action_contact.go Show resolved Hide resolved
engine/action_contact.go Show resolved Hide resolved
engine/action_contact.go Show resolved Hide resolved
actions/admin/contact.go Show resolved Hide resolved
@arkadiuszos4chain
Copy link
Contributor

I forgot to include two additional endpoints in the ticket. Please implement the following:

DELETE admin/contact/{id}
PATCH admin/contact/accepted/{id}

My apologies

@pawellewandowski98 pawellewandowski98 force-pushed the feat-750-add-admin-contact-endpoints branch from 695f31c to 6a7d3b3 Compare April 22, 2024 14:29
@pawellewandowski98 pawellewandowski98 force-pushed the feat-750-add-admin-contact-endpoints branch from 6a7d3b3 to a88e0f7 Compare April 24, 2024 08:06
@jakubmkowalski jakubmkowalski added the tested PR was tested by a team member label Apr 24, 2024
@pawellewandowski98 pawellewandowski98 merged commit da294a2 into main Apr 24, 2024
13 checks passed
@pawellewandowski98 pawellewandowski98 deleted the feat-750-add-admin-contact-endpoints branch April 24, 2024 12:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants