fix: upsert contact didn't work with accessKeys #556
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike as we do for the other contact endpoints, the
upsert
endpoint function relied onxpub
instead ofxpub_hash
.Because the -web-backend uses
accessKeys
for requests authorization, the upsert didn't work.More context here:
https://github.com/bitcoin-sv/spv-wallet/blob/fix-upsert-contact/server/auth/middleware.go#L81-L120
Pull Request Checklist