Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(SPV-729) the rest filters #569

Merged
merged 17 commits into from
May 10, 2024
Merged

feat(SPV-729) the rest filters #569

merged 17 commits into from
May 10, 2024

Conversation

chris-4chain
Copy link
Contributor

@chris-4chain chris-4chain commented Apr 26, 2024

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

Copy link

github-actions bot commented Apr 26, 2024

Manual Tests

πŸ’š Manual testing by @kuba-4chain resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 31.29771% with 180 lines in your changes are missing coverage. Please review.

Project coverage is 52.54%. Comparing base (14f361a) to head (342c0b2).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
+ Coverage   52.37%   52.54%   +0.16%     
==========================================
  Files         198      202       +4     
  Lines       11115    11191      +76     
==========================================
+ Hits         5822     5880      +58     
- Misses       4740     4755      +15     
- Partials      553      556       +3     
Flag Coverage Ξ”
unittests 52.54% <31.29%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
actions/contacts/models.go 0.00% <ΓΈ> (ΓΈ)
actions/destinations/count.go 0.00% <ΓΈ> (ΓΈ)
actions/destinations/search.go 0.00% <ΓΈ> (ΓΈ)
actions/transactions/count.go 0.00% <ΓΈ> (ΓΈ)
actions/transactions/search.go 0.00% <ΓΈ> (ΓΈ)
engine/action_access_key.go 0.00% <ΓΈ> (ΓΈ)
engine/action_contact.go 48.37% <100.00%> (ΓΈ)
engine/action_destination.go 54.83% <ΓΈ> (ΓΈ)
engine/action_draft_transaction.go 23.07% <ΓΈ> (ΓΈ)
engine/action_utxo.go 44.15% <ΓΈ> (ΓΈ)
... and 38 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 14f361a...342c0b2. Read the comment docs.

@chris-4chain chris-4chain marked this pull request as ready for review April 29, 2024 12:05
@chris-4chain chris-4chain requested a review from a team as a code owner April 29, 2024 12:05
models/filter/paymail_filter.go Outdated Show resolved Hide resolved
models/filter/paymail_filter.go Outdated Show resolved Hide resolved
actions/utxos/search.go Show resolved Hide resolved
models/filter/xpub_filter.go Outdated Show resolved Hide resolved
models/filter/access_key_filter.go Outdated Show resolved Hide resolved
models/filter/utxo_filter.go Outdated Show resolved Hide resolved
models/filter/paymail_filter.go Outdated Show resolved Hide resolved
models/filter/paymail_filter.go Outdated Show resolved Hide resolved
@kuba-4chain kuba-4chain added the tested PR was tested by a team member label May 9, 2024
@chris-4chain chris-4chain merged commit 1194719 into main May 10, 2024
13 checks passed
@chris-4chain chris-4chain deleted the feat-729-the-rest-filters branch May 10, 2024 07:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants