Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SPV-807: adjust shared config #597

Merged
merged 6 commits into from
May 28, 2024
Merged

Conversation

Nazarii-4chain
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@Nazarii-4chain Nazarii-4chain requested a review from a team as a code owner May 23, 2024 09:15
@Nazarii-4chain Nazarii-4chain self-assigned this May 23, 2024
Copy link

github-actions bot commented May 23, 2024

Manual Tests

πŸ’š Manual testing by @chris-4chain resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

Attention: Patch coverage is 56.77419% with 67 lines in your changes are missing coverage. Please review.

Project coverage is 49.33%. Comparing base (38fd49f) to head (8106355).
Report is 15 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
+ Coverage   49.23%   49.33%   +0.09%     
==========================================
  Files         248      255       +7     
  Lines       11865    12018     +153     
==========================================
+ Hits         5842     5929      +87     
- Misses       5453     5505      +52     
- Partials      570      584      +14     
Flag Coverage Ξ”
unittests 49.33% <56.77%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
actions/admin/routes.go 100.00% <ΓΈ> (ΓΈ)
actions/sharedconfig/routes.go 100.00% <100.00%> (ΓΈ)
docs/docs.go 0.00% <ΓΈ> (ΓΈ)
engine/script/template/p2pkh.go 100.00% <100.00%> (ΓΈ)
server/server.go 43.13% <100.00%> (+1.13%) ⬆️
actions/sharedconfig/get.go 0.00% <0.00%> (ΓΈ)
engine/pike/pike.go 70.00% <70.00%> (ΓΈ)
engine/script/template/evaluate.go 73.33% <73.33%> (ΓΈ)
engine/types/type42/test_helpers.go 0.00% <0.00%> (ΓΈ)
engine/types/type42/linking_key.go 64.10% <64.10%> (ΓΈ)
... and 1 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 38fd49f...8106355. Read the comment docs.

docs/docs.go Outdated Show resolved Hide resolved
@chris-4chain chris-4chain added the tested PR was tested by a team member label May 28, 2024
@Nazarii-4chain Nazarii-4chain merged commit cf3d33a into main May 28, 2024
8 checks passed
@Nazarii-4chain Nazarii-4chain deleted the SPV-807/adjustSharedConfig branch May 28, 2024 09:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants