Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(SPV-000): define project name in start.sh to have reusable environment across all repositories #617

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

dorzepowski
Copy link
Collaborator

@dorzepowski dorzepowski commented Jun 7, 2024

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@dorzepowski dorzepowski requested a review from a team as a code owner June 7, 2024 12:40
Copy link

github-actions bot commented Jun 7, 2024

Manual Tests

πŸ’š Manual testing by @chris-4chain resulted in success.

@dorzepowski dorzepowski changed the title feat(SPV-000): define project name in start.sh to have reusable envir… feat(SPV-000): define project name in start.sh to have reusable environment across all repositories Jun 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 48.91%. Comparing base (3114e9e) to head (bfc0a15).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #617   +/-   ##
=======================================
  Coverage   48.91%   48.91%           
=======================================
  Files         259      259           
  Lines       12160    12160           
=======================================
  Hits         5948     5948           
  Misses       5616     5616           
  Partials      596      596           
Flag Coverage Ξ”
unittests 48.91% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 3114e9e...bfc0a15. Read the comment docs.

@chris-4chain
Copy link
Contributor

testing πŸ§ͺ

@chris-4chain chris-4chain added the tested PR was tested by a team member label Jun 10, 2024
@chris-4chain chris-4chain merged commit d58c30e into main Jun 10, 2024
13 checks passed
@chris-4chain chris-4chain deleted the start-sh-compose-project-name branch June 10, 2024 10:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants