Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(SPV-1471): add configs shared v2 endpoint #897

Merged
merged 8 commits into from
Feb 12, 2025

Conversation

pawellewandowski98
Copy link
Contributor

Description

  • Added new v2 endpoint - /api/v2/configs/shared

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@pawellewandowski98 pawellewandowski98 self-assigned this Feb 8, 2025
@pawellewandowski98 pawellewandowski98 requested a review from a team as a code owner February 8, 2025 09:19
Copy link

github-actions bot commented Feb 8, 2025

Manual Tests

💚 Manual testing by @dorzepowski resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.72%. Comparing base (23c44fa) to head (be884cd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #897      +/-   ##
==========================================
+ Coverage   52.68%   52.72%   +0.03%     
==========================================
  Files         403      406       +3     
  Lines       17966    17993      +27     
==========================================
+ Hits         9466     9487      +21     
- Misses       7749     7753       +4     
- Partials      751      753       +2     
Flag Coverage Δ
unittests 52.72% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
actions/sharedconfig/get.go 100.00% <100.00%> (ø)
actions/v2/admin/server.go 100.00% <100.00%> (ø)
actions/v2/admin/status.go 100.00% <100.00%> (ø)
actions/v2/base/server.go 100.00% <100.00%> (ø)
actions/v2/base/shared_config.go 100.00% <100.00%> (ø)
actions/v2/server.go 100.00% <100.00%> (ø)
api/gen.api.go 83.33% <100.00%> (+7.33%) ⬆️
api/gen.models.go 0.00% <ø> (ø)
server/server.go 12.19% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c44fa...be884cd. Read the comment docs.

api/components/responses.yaml Show resolved Hide resolved
api/endpoints/base.yaml Outdated Show resolved Hide resolved
actions/v2/base/shared_config.go Outdated Show resolved Hide resolved
@dorzepowski dorzepowski added regression-tests Runs regression tests tested PR was tested by a team member and removed regression-tests Runs regression tests labels Feb 11, 2025
@dorzepowski dorzepowski merged commit 9494183 into main Feb 12, 2025
34 of 38 checks passed
@dorzepowski dorzepowski deleted the feat/SPV-1476-shared-config-endpoint branch February 12, 2025 08:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
regression-tests Runs regression tests tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants