test: legacy descriptors #1130
Open
test: legacy descriptors #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realeinherjar
commented
Sep 20, 2023
realeinherjar
commented
Sep 20, 2023
Comment on lines
-1200
to
+1320
| "shoulld be ok when outpoint does match psbt_input" | ||
| "should be ok when outpoint does match psbt_input" |
There was a problem hiding this comment.
This typo was autofixed by my linter.
40 tasks
|
This is ready, Cc @notmandatory and @danielabrozzoni. (PS: Thanks for all the help, Daniela) |
realeinherjar
commented
Oct 1, 2023
| @@ -12,7 +12,7 @@ members = [ | |||
| "example-crates/wallet_esplora_blocking", | |||
| "example-crates/wallet_esplora_async", | |||
| "nursery/tmp_plan", | |||
| "nursery/coin_select" | |||
| "nursery/coin_select", | |||
realeinherjar
commented
Oct 1, 2023
Comment on lines
-154
to
+170
| #[allow(unused_mut)] | ||
| #[allow(unused_mut)] |
realeinherjar
force-pushed
the
einherjar/legacy-tests
branch
from
e47eedb to
d5bf32c
Compare
realeinherjar
commented
Oct 1, 2023
Comment on lines
+464
to
+473
| /// A floating point assert! that takes an additional third argument `delta` | ||
| /// as a tolerance value when test for equality the first and second argument. | ||
| macro_rules! assert_delta { | ||
| ($x:expr, $y:expr, $d:expr) => { | ||
| if !($x - $y < $d || $y - $x < $d) { | ||
| panic!(); | ||
| } | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
This the way I've found to ignore rounding errors when comparing FeeRate::from_sat_per_vb after the wallet signed with PKH descriptor.
There was a problem hiding this comment.
I think once #1141 is in you'll be able to use a different function to compare fee rates like to_sat_per_kwu(self) or to_sat_per_vb_ceil(self).
fix: typo
realeinherjar
force-pushed
the
einherjar/legacy-tests
branch
from
d5bf32c to
600824e
Compare
|
I think the proposed tests are useful and a great addition. However the PR has become stale and I guess we could move it out from |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently don't have much tests with legacy descriptors (
pkh).This PR adds some, mainly focused on fee stuff.
Notes to the reviewers
This discussion came up on #1115 and also in #1129 (it doesn't fully close).
Changelog notice
Added
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: