Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

(maintenance) doc(bdk): Clarify the absolute_fee docs #1159

Merged
merged 1 commit into from
Oct 22, 2024
Merged

(maintenance) doc(bdk): Clarify the absolute_fee docs #1159

merged 1 commit into from
Oct 22, 2024
+10 −0

Conversation

danielabrozzoni
Copy link
Member

Fixes #1066

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@danielabrozzoni danielabrozzoni mentioned this pull request Oct 9, 2023
Closed
@danielabrozzoni danielabrozzoni changed the title doc(bdk): Clarify the absolute_fee docs (maintenance) doc(bdk): Clarify the absolute_fee docs Oct 9, 2023
@danielabrozzoni danielabrozzoni self-assigned this Oct 9, 2023
@danielabrozzoni danielabrozzoni force-pushed the maintenance/doc/absolute_fee branch 2 times, most recently from e25edbb to f22f1c2 Compare October 11, 2023 11:16
@danielabrozzoni danielabrozzoni force-pushed the maintenance/doc/absolute_fee branch from f22f1c2 to bd6d46b Compare November 8, 2023 17:29
notmandatory
notmandatory approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bd6d46b

Thanks for back porting this doc change.

@danielabrozzoni danielabrozzoni mentioned this pull request Feb 26, 2024
Closed
@nondiremanuel nondiremanuel added this to the 1.0.0-alpha milestone Feb 27, 2024
storopoli
storopoli suggested changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to link the types.

src/wallet/tx_builder.rs Outdated Show resolved Hide resolved
src/wallet/tx_builder.rs Outdated Show resolved Hide resolved
@notmandatory notmandatory modified the milestones: 1.0.0-alpha, 0.30.0 Mar 4, 2024
@notmandatory
Copy link
Member

notmandatory commented Mar 18, 2024 •
edited
Loading

This one should just need a rebased after #1366 and then is ready to merge.

@notmandatory notmandatory added documentation Improvements or additions to documentation module-wallet labels Mar 18, 2024
@danielabrozzoni danielabrozzoni force-pushed the maintenance/doc/absolute_fee branch from bd6d46b to 86566e9 Compare April 18, 2024 10:51
@danielabrozzoni
Copy link
Member Author

@storopoli your comments made me realize that the docs included references to types that aren't actually public (FeePolicy and variants), so I reworded a sentence. What do you think?

@notmandatory thanks, I rebased on top of #1366 and acked that PR.

storopoli
storopoli approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 86566e9

Just a minor comment, feel free to ignore it.

src/wallet/tx_builder.rs Outdated Show resolved Hide resolved
@notmandatory notmandatory modified the milestones: 0.30.0, 0.29.1 Oct 20, 2024
@notmandatory notmandatory force-pushed the maintenance/doc/absolute_fee branch from 86566e9 to ca5726f Compare October 22, 2024 01:39
notmandatory
notmandatory approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ca5726f

@notmandatory notmandatory merged commit ca5726f into bitcoindevkit:release/0.29 Oct 22, 2024
38 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

@storopoli storopoli storopoli approved these changes

Assignees

@danielabrozzoni danielabrozzoni

Labels
documentation Improvements or additions to documentation module-wallet
Projects
BDK Maintenance
Archived in project
Milestone
0.30.0
Development

Successfully merging this pull request may close these issues.
4 participants
@danielabrozzoni @notmandatory @storopoli @nondiremanuel