fix: add excess to changeless LowestFee score
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still think it's wrong after this. Why are we adding the lower bound thing to it. In the case of no drain the metric should just be: cc @evanlinjin |
|
Just noting that I've talked with @evanlinjin and I'm now in charge of fixing it. |
|
Thanks for the update. Feel free to close this PR if you'll be opening a new one. |
|
@evanlinjin can you close this PR and give me permission to manage this repo. |
evanlinjin
added a commit
that referenced
this pull request
Jan 15, 2024
6ae0fdf docs: fix typos and use better wording (志宇) 9e1cecd Use ChangePolicy::min_value in lowest fee tests (LLFourn) 7360052 Write lowest fee test that hits important branch (LLFourn) 17cc8f2 Score branches before adding children (LLFourn) e30246d Fix lowest_fee metric (LLFourn) 0aef6ff Make lowest fee test fail by implementing score correctly (LLFourn) 0c66696 Rethink is_target_met (LLFourn) Pull request description: This replaces #11. This first commit just fixes the metric to make the tests fail. Note the previous calculation was overthinking it. The fee metric is just `inputs - outputs + long_term_feerate * change_weight`. Next steps: 1. Make ci actually run the tests and get them to fail. 2. Fix the metric lower bound ACKs for top commit: evanlinjin: ACK 6ae0fdf Tree-SHA512: c9c684ed95bc946e7e1ad8d65cd03f15180ba0bbc4e901d0e55145006629063fd110a3a08307f3e8c091ff875e41492bebc31895819455b58cc6a137b56103bc
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the part of #6 relating to bitcoindevkit/bdk#1072 (comment).
For the
LowestFeemetric, it adds the excess to changeless solutions instead of those with change.