Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Convert module to TypeScript #37

Closed
jswalden opened this issue Apr 1, 2024 · 0 comments · Fixed by #38
Closed

Convert module to TypeScript #37

jswalden opened this issue Apr 1, 2024 · 0 comments · Fixed by #38
Assignees

Comments

@jswalden
Copy link
Collaborator

jswalden commented Apr 1, 2024

I grumped in #33 about how I was adding jsdoc @type tags all over in an attempt to have poor-man's typing of all my changes, but really the code would be better served by actual types enforced by an actual compiler.

Now that I've been given maintainer access, and the previous maintainer has pretty much disclaimed knowledge/interest here, I get to make my wish reality. :-) I don't think TypeScript is so terribly different from JavaScript as to be a huge burden on anyone proposing patches, and the typing benefits are worth a little inconvenience.

These changes are atop #36 and will, like that change, not be part of the 3.0.0 release but of a future release.

jswalden added a commit to jswalden/companion-module-ptzoptics-visca that referenced this issue Apr 1, 2024
@jswalden jswalden self-assigned this Apr 1, 2024
jswalden added a commit to jswalden/companion-module-ptzoptics-visca that referenced this issue Apr 1, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant