-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix IconOnly issue in anchor mode of BitActionButton (#10030) #10031
Fix IconOnly issue in anchor mode of BitActionButton (#10030) #10031
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe change updates the rendering logic within the BitActionButton component. It now only renders the ChildContent when both conditions are met: ChildContent is not null and IconOnly is false. This modification ensures that for icon-only buttons, the additional content is not rendered. No alterations have been made to the declarations of public entities. Changes
Sequence Diagram(s)sequenceDiagram
participant B as BitActionButton
participant R as Renderer
B->>B: Check if ChildContent exists
B->>B: Check if IconOnly is false
alt ChildContent exists and IconOnly is false
B->>R: Render ChildContent
else
B-->>R: Skip rendering ChildContent
end
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
closes #10030
Summary by CodeRabbit