Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BUG] mat-select-search-no-entries-found persists after panel closes #107

Closed
aronnebrivio opened this issue Feb 27, 2019 · 4 comments · Fixed by #109
Closed

[BUG] mat-select-search-no-entries-found persists after panel closes #107

aronnebrivio opened this issue Feb 27, 2019 · 4 comments · Fixed by #109
Assignees
Labels
bug Something isn't working

Comments

@aronnebrivio
Copy link

Describe the bug
mat-select-search-no-entries-found class persists after panel closes. This causes a blank-mat-option-like space before real mat-options until clicking on "X" button to clear filter.

To Reproduce
(based on https://stackblitz.com/github/bithost-gmbh/ngx-mat-select-search-example)

  1. Click on the first select input
  2. Search for something doesn't exists (like "aaaa")
  3. Un-blur the input (both pressing ESC or clicking away), the selector closes
  4. Open selector again
    => The list will have a blank option on top (see attached screenshot)

Expected behavior
The _reset() function should be fired also on blur

Screenshots
Before
schermata 2019-02-27 alle 17 51 36

After
schermata 2019-02-27 alle 17 41 32

Desktop

  • OS: MacOS 10.14.3
  • Browser: Chrome
  • Version: 72.0.3626.119

Notes
This doesn't happen if there're search results or if the "X" key is clicked to reset the search.

@aronnebrivio aronnebrivio added the bug Something isn't working label Feb 27, 2019
@macjohnny
Copy link
Member

Thanks a lot for reporting this issue!
Would you like to file a PR to fix the issue?

@aronnebrivio
Copy link
Author

Sorry I'm a bit late, I didn't see your response.
Waiting for the fix to be pushed on production, thanks! :)

@macjohnny
Copy link
Member

@aroblu94 i will release version 1.5.3 later today

@macjohnny
Copy link
Member

the fix was released with version 1.5.3

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants