-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Document system:authenticated group usage in GKE #1448
Comments
use of system:authenticated is more than discouraged; from google docs |
From your quote, it says that you won't be able to bind the We are not doing that. We are binding a custom |
@alemorcuq Correct, I read that part wrong -- they will just flag any use of system:authenticated as potentially insecure in console popups and emails that make administrators like me (who haven't touched sealed secrets) panic a bit. Apologies. |
**Description of the change** Add options to the Helm chart to configure the `proxier` Role, and its RoleBinding. **Benefits** This allows the user to override the default RoleBinding that grants `system:authenticated` the `proxier` role. `system:authenticated` is not a very safe option in a lot of clusters, so it's important to expose this option. **Possible drawbacks** This was written to preserve existing behavior by default, so as to not break compatibility. This isn't ideal as the existing behavior is insecure on GKE (and possibly other contexts as well), but since it doesn't directly expose anything damaging (but rather is a defense-in-depth measure), it's probably OK to just highlight the importance of changing this in the documentation. **Applicable issues** - partially addresses #1448 Signed-off-by: Alice Sawatzky <alice.sawatzky@farmersedge.ca>
We are binding the
system:authenticated
group to theservice-proxier
role so thatkubeseal
can easily communicate with thecontroller
to get the public key and encrypt your secrets. This role only has permissions to get thesealed-secrets
service and to makePOST
andGET
requests to that service.In GKE, the use of
system:authenticated
is discouraged because anyone with a Google account is assigned to that group. Here's a recent KubeCon talk on this topic that mentions our use case.While nothing sensitive is exposed to users on that group, we should document this in our GKE documention. We should also add an option in the chart to allow users to disable the creation of the
service-proxier
service.The text was updated successfully, but these errors were encountered: