Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[bitnami/argo-cd] Add missing verbs to ApplicationSet role #28914

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

jemand771
Copy link
Contributor

Description of the change

Add missing verbs (list, watch) to the ApplicationSet controller's role.

Benefits

The new verbs are required since a recent update. Not granting them in the role results in errors in the ApplicationSet controller's logs, e.g.

(without list)

W0816 22:58:18.236433       1 reflector.go:539] pkg/mod/k8s.io/client-go@v0.29.6/tools/cache/reflector.go:229: failed to list *v1alpha1.AppProject: appprojects.argoproj.io is forbidden: User "system:serviceaccount:argocd:argocd-argo-cd-applicationset-controller" cannot list resource "appprojects" in API group "argoproj.io" in the namespace "argocd"

(without watch)

E0816 23:20:09.253511       1 reflector.go:147] pkg/mod/k8s.io/client-go@v0.29.6/tools/cache/reflector.go:229: Failed to watch *v1alpha1.AppProject: unknown (get appprojects.argoproj.io)

Possible drawbacks

Overly broad privileges when overriding the controller's image to an older version. Not relevant imo

Applicable issues

n/a

Additional information

I've also tested these changes using chart version 7.0.0 and a quick kubectl edit role -n argocd argocd-argo-cd-applicationset-controller

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Willy Hille <jemand771@gmx.net>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Aug 17, 2024
@github-actions github-actions bot removed the triage Triage is needed label Aug 17, 2024
@github-actions github-actions bot removed the request for review from javsalgar August 17, 2024 10:07
@github-actions github-actions bot requested a review from fmulero August 17, 2024 10:07
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @jemand771 for sharing this fix.

LGTM

@fmulero fmulero merged commit 69e8d7b into bitnami:main Aug 19, 2024
9 checks passed
@jemand771 jemand771 deleted the argo-cd-fix-appset-role branch August 19, 2024 07:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
argo-cd solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants