Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Only push images from bitnami/minideb repository #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jerrykan
Copy link
Contributor

Make it so that only builds triggered by the bitnami/minideb repository will attempt to push images (because it is the only repository that has access to the required secrets). This will prevent builds in forked repositories that don't have access to the secrets from failing.

@jerrykan
Copy link
Contributor Author

I forgot the DCO/Signed-off-by tags in my original commits, that should be fixed in the updated commit.

@carrodher
Copy link
Member

Thanks for creating this PR. Please, note it is needed to sign the commits. Your signature certifies that you wrote the patch or otherwise have the right to contribute the material. You can find more info about this topic, in the “Sign your work” section from the contributing guidelines.

In this link you can find more info about how to fix the current issue

Make it so that only builds triggered by the `bitnami/minideb`
repository will attempt to push images (because it is the only
repository that has access to the required secrets). This will prevent
builds in forked repositories that don't have access to the secrets from
failing.

Signed-off-by: John Kristensen <john@jerrykan.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants