Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Stop using call_price when globally settling after the hard fork #1669

Closed
2 of 17 tasks
abitmore opened this issue Mar 23, 2019 · 1 comment
Closed
2 of 17 tasks

Stop using call_price when globally settling after the hard fork #1669

abitmore opened this issue Mar 23, 2019 · 1 comment
Assignees
@abitmore
Labels
hardfork
Milestone
4.0.0 - Protocol ...

Comments

@abitmore
Copy link
Member

abitmore commented Mar 23, 2019 •
edited
Loading

User Story
According to current hardfork branch, we still use call_price after the hard fork. We'd like to remove the by_call_price index at some time in the future to improve performance, thus we should avoid using the index after the hardfork. Note: this will change operation history numbering, thus better do it in a hardfork release. Follow-up of #1270. See #1324 (comment) and b494609.

Impacts
Describe which portion(s) of BitShares Core may be impacted by your request. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

Additional Context (optional)
Add any other context about your request here.

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@abitmore abitmore self-assigned this Mar 23, 2019
abitmore added a commit that referenced this issue Mar 23, 2019
@abitmore
Use by_collateral when globally settling after hf
5f8549e 
We'd like to remove `by_price` index at some time in the future to
improve performance, thus we should avoid using the index after the
hardfork.
#1669
@abitmore abitmore mentioned this issue Mar 23, 2019
Merged
abitmore added a commit that referenced this issue Mar 24, 2019
@abitmore
Rewrite globally_settle() with a template function
6faa519 
The distinction before/after hardfork #1270 (Call price inconsistent when MCR changed) now looks clearer.
#1669
@abitmore abitmore mentioned this issue Sep 3, 2019
Open
17 tasks
@pmconrad
Copy link
Contributor

Fixed by #1672

@MichelSantos MichelSantos mentioned this issue Oct 18, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@abitmore abitmore

Labels
hardfork
Projects
None yet
Milestone
4.0.0 - Protocol Upgrade Release
Development

No branches or pull requests
3 participants
@pmconrad @abitmore @ryanRfox