Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Incorporate p2p fixes that were made to steem codebase #411

Closed
dnotestein opened this issue Oct 6, 2017 · 3 comments
Closed

Incorporate p2p fixes that were made to steem codebase #411

dnotestein opened this issue Oct 6, 2017 · 3 comments

Comments

@dnotestein
Copy link

steemit/steem@102fb69
steemit/steem@952e58e

@dnotestein
Copy link
Author

dnotestein commented Oct 6, 2017

These changes prevent a condition where a node stops getting blocks because it gets in a bad sync state with its peers.

@dnotestein
Copy link
Author

This is not a hardfork change, but it's highly recommended that all nodes upgrade to it for more reliable operation.

xeroc pushed a commit that referenced this issue Oct 7, 2017
There was a case where we had requested a block through the sync
mechanism and also received it through the normal inventory mechanism
where we would leave the peer in a sync state, but never ask them
for more sync blocks.

This commit fixes the bug that put us into that stuck state, and also
adds code to disconnect peers if we ever manage to get into that stalled
state.
oxarbitrage added a commit that referenced this issue Oct 7, 2017
@oxarbitrage
Copy link
Member

closing issue as code from the mentioned commits is now merged.

@pmconrad pmconrad mentioned this issue Oct 9, 2017
yoyowd referenced this issue in yoyow-org/yoyow-core Sep 6, 2018
There was a case where we had requested a block through the sync
mechanism and also received it through the normal inventory mechanism
where we would leave the peer in a sync state, but never ask them
for more sync blocks.

This commit fixes the bug that put us into that stuck state, and also
adds code to disconnect peers if we ever manage to get into that stalled
state.
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants