Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

object_database created outside of witness data directory when witness_node is started with --replay #436

Closed
abitmore opened this issue Oct 20, 2017 · 3 comments
Closed

object_database created outside of witness data directory when witness_node is started with --replay #436

abitmore opened this issue Oct 20, 2017 · 3 comments
Labels
bug
Milestone
201803 Non-Consen...

Comments

@abitmore
Copy link
Member

Steps to reproduce with test-2.0.171008 tag:

  • run ./witness_node
  • a while after started and getting blocks, press Ctrl+C
  • run ./witness_node --replay, then an object_database directory will be created under current directory
@pmconrad pmconrad self-assigned this Oct 21, 2017
@pmconrad
Copy link
Contributor

With --replay-blockchain, database::wipe is called before opening the database.
database::wipe calls database::close before wiping, database::close calls object_database::flush, which writes the current contents (i. e. nothing) to a default-initialized (i. e. empty) fc::path.

@abitmore abitmore mentioned this issue Nov 13, 2017
Closed
@abitmore abitmore added this to the Future Non-Consensus-Changing Release milestone Nov 27, 2017
@abitmore abitmore added the bug label Dec 21, 2017
@windycrypto
Copy link
Member

windycrypto commented Feb 23, 2018 •
edited
Loading

It seems _data_dir only be passed to object_database via open method, while wipe method not pass this variable.

So in object_database::flush() the object_database dir was created at current directory

@pmconrad pmconrad mentioned this issue Feb 24, 2018
Closed
@windycrypto windycrypto mentioned this issue Feb 25, 2018
Merged
@abitmore abitmore modified the milestones: Future Non-Consensus-Changing Release, Next Non-Consensus-Changing Release Feb 25, 2018
abitmore added a commit that referenced this issue Feb 28, 2018
@abitmore
Merge pull request #689 from cifer-lee/issue121

Unverified

The committer email address is not verified.
Learn about vigilant mode
4e591a6 
Fix #436 object_database created outside of witness data directory
@abitmore
Copy link
Member Author

This has been done.

xeroc pushed a commit that referenced this issue Mar 20, 2018
@xeroc
Fix #436 object_database created outside of witness data directory

Unverified

The committer email address is not verified.
Learn about vigilant mode
60e9039
xeroc pushed a commit that referenced this issue Mar 21, 2018
@xeroc
Fix #436 object_database created outside of witness data directory

Unverified

The committer email address is not verified.
Learn about vigilant mode
d3b6a66
@pmconrad pmconrad mentioned this issue Jul 31, 2018
Merged
4 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
201803 Non-Consensus-Changing Release
Development

No branches or pull requests
3 participants
@windycrypto @pmconrad @abitmore