Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Changing backing asset ID runs some checks against the old value instead of the new. #931

Closed
jmjatlanta opened this issue May 17, 2018 · 2 comments

Comments

@jmjatlanta
Copy link
Contributor

jmjatlanta commented May 17, 2018

Some checks examine the existing backing asset's properties instead of those of the new backing asset.

The offending line is here:

const asset_object& backing = a.bitasset_data(d).options.short_backing_asset(d);

Checks should be performed on the incoming backing bitasset, not on the existing backing bitasset.

@jmjatlanta jmjatlanta self-assigned this May 17, 2018
@btsabc
Copy link

btsabc commented May 17, 2018

By the way ,add checking for short_backing_asset is not allowed to be set to MPA self.

@abitmore abitmore self-assigned this May 17, 2018
@abitmore abitmore added this to the 201805 - Consensus Changing Release milestone May 17, 2018
@abitmore abitmore removed their assignment May 17, 2018
@abitmore abitmore added the bug label May 17, 2018
abitmore added a commit that referenced this issue May 24, 2018
Issues #922 and #931 bitasset_update checks
@abitmore
Copy link
Member

Fixed with #932.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants