Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Issue1034 Get rid of obsolete constants #1072

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Issue1034 Get rid of obsolete constants #1072

merged 1 commit into from
Jun 21, 2018

Conversation

windycrypto
Copy link
Member

@windycrypto windycrypto commented Jun 19, 2018 •
edited
Loading

fix #1034

The deleted constants were never used by any other parts of the repo. And all modules build ok.

@windycrypto windycrypto mentioned this pull request Jun 19, 2018
Closed
8 tasks
@oxarbitrage oxarbitrage self-requested a review June 19, 2018 17:44
oxarbitrage
oxarbitrage approved these changes Jun 19, 2018
View reviewed changes
Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was surprised to see some of this not being used anywhere howver i can confirm none of the ones the pull removes are being used, node builds and replaying fine without them. thanks @cifer-lee

@oxarbitrage oxarbitrage merged commit 11d0432 into bitshares:develop Jun 21, 2018
@pmconrad
Copy link
Contributor

Good job, thanks!

@abitmore abitmore mentioned this pull request Aug 4, 2018
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
201808 - Non-Consensus-Changing Release
Development

Successfully merging this pull request may close these issues.
4 participants
@windycrypto @pmconrad @oxarbitrage @abitmore