Added a comment to block_header struct #1136 #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmjatlanta
approved these changes
Jul 16, 2018
| @@ -34,6 +34,8 @@ namespace graphene { namespace chain { | |||
| fc::time_point_sec timestamp; | |||
| witness_id_type witness; | |||
| checksum_type transaction_merkle_root; | |||
| // Note: when we need to add data to `extensions`, remember to review `database::_generate_block()`. | |||
| // More info in https://github.com/bitshares/bitshares-core/issues/1136 | |||
There was a problem hiding this comment.
Smart. Simple. Effective.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #1136.