Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add voting tests #1211

Merged
merged 1 commit into from
Jul 30, 2018
Merged

add voting tests #1211

merged 1 commit into from
Jul 30, 2018

Conversation

oxarbitrage
Copy link
Member

Testcase for #1191

It is a bit too big as i had to take control of the network by adding my witnesses and my committee. This is a process already done in smartcoin_tests. We need to improve it a bit for general use IMO and add it to fixture maybe.

After that is done, the real test action is done when checking votes at when tracking is enabled:
BOOST_CHECK_EQUAL(witness1_object->total_votes, 111);
and when it is disabled:
BOOST_CHECK_EQUAL(witness1_object->total_votes, 0);

Same is done for the committee members.

@abitmore abitmore changed the base branch from 987-standby-votes-develop to develop July 30, 2018 15:06
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

  • the hack in database_fixture.cpp is debatable,
  • agree with you about the common code,

but we can improve them later.

I've merged #1191 and changed base of this PR to develop.

Travis-CI timed out. I've restarted it. Will merge later.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants