Fix for node crash #1480
Merged
Fix for node crash #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d prevent execution before hf / forbid after hf
oxarbitrage
previously approved these changes
Dec 21, 2018
There was a problem hiding this comment.
as blocks with issues were passed in @pmconrad tests and snapshot comparison is the same i will go with this patch.
abitmore
requested changes
Dec 21, 2018
abitmore
reviewed
Dec 21, 2018
| top.to = GRAPHENE_RELAXED_COMMITTEE_ACCOUNT; | ||
| top.amount = asset( GRAPHENE_MAX_SHARE_SUPPLY ); | ||
| proposal.proposed_transaction.operations.emplace_back( top ); | ||
| ilog( "Issue 1479: ${p}", ("p",proposal) ); |
There was a problem hiding this comment.
Log before adding the transfer to the proposal? I think wlog is better.
abitmore
approved these changes
Dec 21, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1479