Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Testnet consensus release #1609

Merged
merged 115 commits into from
Feb 25, 2019
Merged

Testnet consensus release #1609

merged 115 commits into from
Feb 25, 2019

Conversation

oxarbitrage
Copy link
Member

@oxarbitrage oxarbitrage commented Feb 22, 2019

Merges the testnet_release into testnet with hardfork activation dates Thursday, February 28, 2019 2:02:00 PM

All testnet block producers must upgrade, API nodes are recommended to upgrade too.

abitmore and others added 30 commits September 13, 2018 11:59
Note: this should not break compatibility in production because the result should be the same after hard fork #343.
- initial implementation
- unit tests: added asset_rewards_test, modified create_advanced_uia
- added market_sharing_whitelist option
- added tests for asset extensions before and after the hardfork 1268
- added check asset restrictions while pay reward
- added unit test
jmjatlanta
jmjatlanta previously approved these changes Feb 22, 2019
Copy link
Contributor

@jmjatlanta jmjatlanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiled on Ubuntu 18.04 / OpenSSL 1.1.0 / Boost 1.67 chain_test ran with no errors detected.

@pmconrad
Copy link
Contributor

Can we include a snapshot comparison into our standard release procedure?
We didn't do it for the last one, but I think it would generally be a good idea.

@oxarbitrage
Copy link
Member Author

I created the snapshots between testnet and testnet_release.

When comparing i found 3 objects types that changed their structure by the code we are about to merge, i think they are all ok and explainable by our pull request :

  1. 1.3.X objects changed extensions field format from [] to {}. Distribute Asset Market Fees to Referral Program #1268
  2. 1.13.0 objects added balance_type field. Distribute Asset Market Fees to Referral Program #1268
  3. 2.4.0 objects added maintenance_collateralization field. Call price is inconsistent when MCR changed #1270

Also updated this document: https://github.com/oxarbitrage/documentation/blob/master/snapshot.md

Plan to link it in the release steps of the git flow(https://github.com/bitshares/bitshares-core/wiki/Git-Flow)

@abitmore
Copy link
Member

We should bump DB_VERSION.

Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should bump DB_VERSION.

Actually this should have been done in hardfork branch 9af57a8, but looks like it has been incorrectly overwritten when merging / resolving conflicts (this commit: 54c4c02)

@oxarbitrage
Copy link
Member Author

oxarbitrage commented Feb 25, 2019

pls check #1615 for bump DB and #1614 for new HF dates.

@oxarbitrage
Copy link
Member Author

changed bump db to hardfork branch here #1616

TESTNET - change hf dates to Thursday, February 28, 2019 2:02:00 PM
@oxarbitrage
Copy link
Member Author

bringing bump db from hardfork at #1617

bring bump db from hardfork to testnet release
@abitmore abitmore mentioned this pull request Feb 25, 2019
17 tasks
Copy link
Contributor

@jmjatlanta jmjatlanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiled on Ubuntu 18.10 / Boost 1.67 / OpenSSL 1.1.0. chain_test completed with no errors found.

@oxarbitrage oxarbitrage merged commit bf7ff54 into testnet Feb 25, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants