Skip to content

Change operation_history to generic_index, #403 #464

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Nov 8, 2017

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Nov 7, 2017

For #403

@oxarbitrage
Copy link
Member

getting error when starting node with changes:

...
2404818ms th_a       undo_database.hpp:68          ~session             ] 10 assert_exception: Assert Exception
maybe_found != nullptr: Unable to find Object
    {"id":"0.0.0"}
    th_a  index.hpp:111 get

    {}
    th_a  undo_database.cpp:123 undo
terminate called after throwing an instance of 'fc::assert_exception'
Aborted
root@NC-PH-1346-07:~/bitshares/pull464/bitshares-core# 

@abitmore
Copy link
Member Author

abitmore commented Nov 7, 2017

Sorry for that. New commit pushed.

@oxarbitrage oxarbitrage self-requested a review November 7, 2017 21:27
Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working now, nice work.

@abitmore
Copy link
Member Author

abitmore commented Nov 7, 2017

Note: perhaps should bump db_version when releasing.

@abitmore
Copy link
Member Author

abitmore commented Nov 8, 2017

Some data from live test: this change saves around 500M of RAM with current chain (head_block ~= 21614538) and default config(max-ops-per-account = 1000 and partial-operations = true).

@abitmore abitmore merged commit 7cf7cd2 into bitshares:develop Nov 8, 2017
@pmconrad
Copy link
Contributor

pmconrad commented Nov 8, 2017

Wow, I didn't expect that much!

@abitmore abitmore added this to the Next Non-Consensus-Changing Release - 201712 milestone Nov 28, 2017
@abitmore abitmore deleted the 403-ophis-index-change branch June 28, 2021 21:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants