Partially fix #511 assert() issue #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmconrad
approved these changes
Jan 21, 2018
pmconrad
reviewed
Jan 21, 2018
| @@ -229,7 +229,7 @@ namespace graphene { namespace chain { | |||
|
|
|||
| account_id_type fee_payer()const { return account; } | |||
| void validate()const { | |||
| FC_ASSERT( amount.amount > 0, "Must settle at least 1 unit" ); | |||
| FC_ASSERT( !"virtual operation" ); | |||
| } | |||
There was a problem hiding this comment.
Hm, perhaps this requires a hardfork after all? What if the op turns up in a proposal?
There was a problem hiding this comment.
Yes, you're correct. I'll revert this change. Let's fix it more carefully in another PR.
abitmore
force-pushed
the
511-assert-db-block
branch
from
cc4bd2e to
68996fb
Compare
|
Reverted the code for #588. Please review again. |
pmconrad
approved these changes
Jan 21, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a few
assert()toFC_ASSERT()which is described in #511 and also some other code related.bitshares/bitshares-fc#9 need to be merged and appended to this PR.