Bump FC for ninja build #859 and stacktrace #727 #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should include the openssl-1.1 stuff as well. |
|
openssl 1.1 stuff will break the build, so best to open another PR and fix the build at same time. Some people need this PR. |
abitmore
changed the title
jmjatlanta
approved these changes
Apr 30, 2018
There was a problem hiding this comment.
This bump also includes #800, which is already merged in to the master branch of fc. I'm not sure if that is on purpose, and I don't have a problem with it being included here. But I want all to be aware.
|
@jmjatlanta it's intended. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #859, fix #727.