remove verify_account_history_plugin_index()

[oxarbitrage]

function verify_account_history_plugin_index() in the test cases do return immediately after it is called, ignoring the body on it fully. haves no sense to keep or use IMO(maybe i am missing something), this PR remove function and calls to it.

[abitmore]

I think we need to fix it rather than removing it. Maybe add similar tests for other plugins.

[ryanRfox]

I believe this is a Protocol Impacting Issue. If so, may I request @oxarbitrage @abitmore to Label it and place it on the proper Release (remove the incorrect one, as I assigned it to both).

[oxarbitrage]

not protocol update here. what happens is that the code in question is not active in the moment so i removed it. @abitmore think the code should be fixed instead of removed. I didn't had the time to take a look on how hard to fix it yet however this is something we probably can do in the next release.

[ryanRfox]

@oxarbitrage Thanks for clarifying the Release placement. May I request you add the reference to the Issue number? I am unable to locate an Issue this fixes.

[oxarbitrage]

there is no issue for this, just the pull at the moment.

[cogutvalera]

maybe we should create issue for this PR ?

[pmconrad]

AFAICS the commented-out code checks some mapping of accounts to addresses.
That doesn't make sense at all, so I don't see how this could be fixed, therefore I approve removal.
(Feel free to disagree ofc.)

[abitmore]

I agree. The last related commit is this: a0765e2, which removed a lot of code but left some commented out. According to changes and the commit comment, the commented out code doesn't make sense any more.